Resolve issue #297 #318
Resolve issue #297 #318
Conversation
t/greppable.t
Outdated
| @@ -35,6 +35,9 @@ $t.test-gist(‘“…” is added to long paths’, | |||
| $t.test-gist(‘“…” is not added to root files’, | |||
| %(‘result.md’ => none /‘``…/README.md``’/)); | |||
|
|
|||
| $t.test(‘single line/module returned’, | |||
| “{$t.bot-nick}: 6lang”, | |||
There was a problem hiding this comment.
This is fine but fragile, I'd go with something like:
<AlexDaniel> greppable: ought to cover the same functionality as this class, maybe long-term we
<greppable6> AlexDaniel, 1 lines, 1 modules: https://gist.github.com/fafdd7e108cdd382ddf0d7a536f80385
This is pretty much guaranteed to always return one module.
bin/Greppable.p6
Outdated
| @@ -105,8 +105,20 @@ multi method irc-to-me($msg) { | |||
| } | |||
| my $total = $stats.elems; | |||
| my $modules = $stats.Set.elems; | |||
| (‘’ but FileStore({ ‘result.md’ => $gist })) | |||
| but PrettyLink({“$total lines, $modules modules: $_”}) | |||
| if $total == 1 and $modules == 1 { | |||
There was a problem hiding this comment.
I somewhat dislike the copy-pasta here. What about:
but PrettyLink({“{s $total, ‘line’}, {s $modules, ‘module’}: $_”})
|
Hello, any update on this? I'm very eager to merge this during the squashathon later today, but it would be nice to have the mentioned tweaks implemented. |
|
My apologies but I have not had time to implement the changes you've suggested. Hopefully this can serve as LHF for new comers during this squashathon. |
There's an “s” sub which is a quick hack, but it allows to temporarily write things like this in a better way.
There's a high chance that “6lang” will be included in more than one repository, so it's better to use some longer string.
Otherwise I'm seeing some infrequent failures locally.
|
OK, did some tweaks to the PR and merged it. Thank you! |
No description provided.