Implement \U00000 syntax handling for Unicodable #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDaniel
requested changes
Jun 1, 2018
t/unicodable.t
Outdated
| # https://github.com/perl6/whateverable/issues/234 | ||
| $t.test(｢\U lookup by code｣, | ||
| “{$t.bot-nick}: \\U0010ffff”, | ||
| /^ <me($t)>‘U+10FFFF <illegal> [] (�)’ $/); |
There was a problem hiding this comment.
Interesting, are you using rakudo 2018.09 or less? The result is different now: https://gist.github.com/b6d312cb369774379a5c61f5a1d7d080
bin/Unicodable.p6
Outdated
| @@ -96,7 +96,7 @@ method from-numerics($query) { | |||
| $query ~~ m:ignoremark/^ | |||
| :i \s* | |||
| [ | |||
| [ | ‘u’ (.) <?{ $0[*-1].Str.uniname.match: /PLUS.*SIGN/ }> | |||
| [ | [｢\U｣ |‘u’ (.)] <?{ $0[*-1].Str.uniname.match: /PLUS.*SIGN/ }> | |||
There was a problem hiding this comment.
I think the closing ] is misplaced and should be at the end of the line, otherwise it expects something like \U+2665 but the tests expect otherwise.
|
By the way, I've added a helpful error (hopefully) if miniircd can't start: 59b1e4c You can also do |
Most likely an oops.
By adapting the output for rakudo 2017.10 and up.
|
Sorry for reopening, but I felt like salvaging it :) Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably fixes #234 but I can't figure out how to run the test suite, so I gave up on it.