Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to specify no extractor #26

Closed
plicease opened this issue Oct 20, 2022 · 6 comments
Closed

Should be able to specify no extractor #26

plicease opened this issue Oct 20, 2022 · 6 comments

Comments

@plicease
Copy link
Member

For when the asset really is the thing that you need and it doesn't need to be further extracted! I think the GitLab version of this already has this.

@zmughal
Copy link
Member

zmughal commented Oct 28, 2022

Yes, I'm coming across this now particularly when I am downloading a binary release (.exe, .msi, .pkg) or when I must use a specific extractor plugin (e.g., Extract::CommandLine).

@plicease
Copy link
Member Author

I was able to work around this by using 'f' as the asset "format"
https://metacpan.org/release/PLICEASE/Alien-ghostunnel-0.01/source/alienfile#L43
I still want to make it possible to turn this off in this plugin but I haven't gotten around to doing it yet.

@zmughal
Copy link
Member

zmughal commented Oct 29, 2022

I still need to run my own extraction code, so I just used an around_hook that does not call the original. Not the best approach but works for now.

@plicease plicease mentioned this issue Oct 31, 2022
@plicease
Copy link
Member Author

#27 should address this. I sort of painted myself into a corner with this one, but with this PR if you set it to none it won't add an extractor, even if you are using the asset mode. I can't think of a situation where you would really not want to extract in tag mode, since that is always a tarball, but no harm I think in having that option even if you never use it.

@plicease
Copy link
Member Author

0.10 should address this!

@plicease
Copy link
Member Author

hopefully we don't ever need to add an extractor called none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants