Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are these includes needed? #5

Closed
enelson1001 opened this issue Nov 14, 2018 · 2 comments
Closed

Are these includes needed? #5

enelson1001 opened this issue Nov 14, 2018 · 2 comments

Comments

@enelson1001
Copy link
Contributor

Per
First off I am no where near your experience as a C++ programmer, I still am a novice.
I was looking thru the code to try an understand how Task Event Queue works (still trying to figure it out) and saw some includes that I had questions on. There may be reason why you include stuff that I am not aware of (maybe future enhancements?) but here is what i have found so far.

TaskEventQueue.h
//
// Created by permal on 6/27/17.
//

#pragma once

#include <smooth/core/Task.h>
#include "ITaskEventQueue.h"
#include "IEventListener.h"
#include "Link.h" //// <----- is this required
#include "QueueNotification.h"
#include <smooth/core/logging/log.h>

QueueNotification.h
//
// Created by permal on 10/18/17.
//

#pragma once

#include
#include
#include
#include
#include <condition_variable> //////////////// <--- added ?????
#include "ITaskEventQueue.h"
#include <smooth/core/timer/ElapsedTime.h> ////////// <---- is this required

namespace smooth
{
namespace core
{
//class Task; ////////////////// <---------Is this required

QueueNotifications.cpp
//
// Created by permal on 10/18/17.
//

#include /// <----- is this required ?
#include <smooth/core/Task.h> /// <------ is this required ?
#include <smooth/core/ipc/QueueNotification.h>
#include <smooth/core/timer/ElapsedTime.h> //// <----- is this required ?
#include <smooth/core/logging/log.h>

Thanks

@PerMalmberg
Copy link
Owner

For a novice, you have a keen eye. :) Some of those might not be needed, and are likely leftovers from earlier iterations. I'll have a look at cleaning the includes.

@PerMalmberg
Copy link
Owner

Some where needed, some where not. Also added an example for the ISRTaskEventQueue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants