Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD does not generate kt version of SYSTEM_ALERT_WINDOW #406

Closed
shiraji opened this issue Nov 26, 2017 · 0 comments
Closed

PD does not generate kt version of SYSTEM_ALERT_WINDOW #406

shiraji opened this issue Nov 26, 2017 · 0 comments

Comments

@shiraji
Copy link
Member

shiraji commented Nov 26, 2017 •
edited

PD version is 3.0.1

if you set NeedsPermission(SYSTEM_ALERT_WINDOW), it won't generate code.

This is because SystemAlertWindowHelper use JavaPoet's ClassName.

https://github.com/permissions-dispatcher/PermissionsDispatcher/blob/master/processor/src/main/kotlin/permissions/dispatcher/processor/impl/kotlin/SystemAlertWindowHelper.kt#L3

Also, I guess onActivityResult method should be extension method of Activity.

I will fix these and add test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shiraji