-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add android.app.Fragment support #31
Comments
The support is already integrated into 2.0.0; I'll do a quick write-ups of how the optional dependency works! |
@aurae @RuntimePermissions(appfragment = true) // naming is quite bad...
public class MainFragment extends android.app.Fragment {
} or @RuntimePermissions(v4ragment = false)
public class MainFragment extends android.app.Fragment {
} if the user can choose whether using native Fragment or not, it would be a good api. |
I think that it would be an even better API if the user didn't have to deal with PermissionsDispatcher's configuration when it comes to fragments. Here is how it works in the new Kotlin architecture:
I don't think it's necessary to have the user deal with which configuration PermissionsDispatcher should use. What issue have you encountered with the optional dependency? |
Oh sorry, I've not seen your PR well, please just a minute. |
It's all good. Take your time! |
Picasso or Retrofit's implementation are very useful for us I guess.
The text was updated successfully, but these errors were encountered: