Compilation - warnings

[lukaspospisil]

Hi guys,

new warnings during compilation:

permon/src/mat/impls/inv/matinv.c: In function ‘MatInvExplicitly_Inv’:

permon/src/qps/impls/mpgp/mpgp.c:557:14: warning: ‘alpha’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         TRY( QPGetScaledProjectedGradient(qp,alpha,galpha) );

permon/src/qps/impls/mpgp/mpgp.c: In function ‘QPSSolve_MPGP’:

permon/src/qps/impls/mpgp/mpgp.c:557:14: warning: ‘alpha’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         TRY( QPGetScaledProjectedGradient(qp,alpha,galpha) );

permon/src/qps/impls/smalxe/smalxe.c: In function ‘QPSSMALXEUpdate_SMALXE’:

petsc-3.7.0/include/petsclog.h:40:46: warning: ‘rho_update’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define PetscInfo2(A,S,a1,a2)                PetscInfo_Private(PETSC_FUNCTION_NAME,A,S,a1,a2)

permon/src/qps/impls/smalxe/smalxe.c:387:17: note: ‘rho_update’ was declared here
   PetscReal     rho_update;

Regards, LP

[haplav]

Hi Lukas,
I've tried to fix this by f2edfbc and 1cfd00e. Could you please check your warnings disappear?
Thank you!
Vaclav

[lukaspospisil]

Hi Vaclav,
yes - the previous warnings are gone. However, there are new ones:

permon/src/mat/impls/inv/matinv.c: In function ‘MatInvExplicitly_Inv’:
permon/src/mat/impls/inv/matinv.c:622:28: warning: ‘scColor’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         iloihi[0] = scColor*floor(M/redundancy);

permon/src/qps/impls/mpgp/mpgp.c: In function ‘QPSSolve_MPGP’:
permon/src/qps/impls/mpgp/mpgp.c:645:10: warning: ‘alpha’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     TRY( QPGetScaledProjectedGradient(qp,alpha,galpha) );

[haplav]

Strange that you have completely different line numbers. Do you know why? Thanks, Vaclav

[haplav]

Sorry, that was my fault. I have now pushed a19a9f9 and 86dd7fa which should fix the warnings. Note that I don't see why the compiler complained in the first case...

[lukaspospisil]

Thank you, I will check warnings as soon as possible.

[lukaspospisil]

Great work! Without any warning (also on Piz Daint supercomputer with Petsc-cuda compilation).

[haplav]

Thank you for cooperation.
Best,
Vaclav