Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simplify mark price #50

Merged
merged 4 commits into from Dec 16, 2022

Conversation

Wraecca
Copy link
Contributor

@Wraecca Wraecca commented Dec 15, 2022

PR Reminders

Be ware of the followings

  • implement deployment script for your changes in deployment repo
  • add verification in hardhat simulation(000-prepare-simulation-check, 902-newMarket-check or 903-simulation-check) and system test(901-system-test) in deployment repo
  • update change log

  1. Contract: make sure the code follows our convention, ex: naming, explicit returns, etc.; if uncertain, discuss with others

  2. Test: make sure tests can cover most normal and edge cases; if not, open follow-up tickets. Also, look out for failed tests and fix them!

  3. CHANGELOG.md: update when external interfaces are changed

  4. Workflow:

    • Github: assign the pr to yourself; if pairing, can merge directly; else, assign someone to help review
    • Asana: assign the corresponding ticket to yourself and leave the pr link on it for easier follow-ups
    • Discord: if someone is mentioned in this pr, tag on Discord

@Wraecca Wraecca self-assigned this Dec 15, 2022
@Wraecca Wraecca marked this pull request as ready for review December 15, 2022 13:52
Copy link
Collaborator

@tailingchen tailingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tailingchen tailingchen merged commit f653cb3 into feature/mark-price Dec 16, 2022
@tailingchen tailingchen deleted the feature/mark-price-rm-ab-registry branch December 16, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants