Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing node engine restriction #204

Closed
bponomarenko opened this issue May 11, 2020 · 1 comment · Fixed by #327
Closed

Missing node engine restriction #204

bponomarenko opened this issue May 11, 2020 · 1 comment · Fixed by #327

Comments

@bponomarenko
Copy link

bponomarenko commented May 11, 2020

Readme file has clear indication of the Node.js version support

Node support
This library is compatibale with NodeJS version 10 and above...

It is good practice to also indicate such requirements in the package.json file itself, which will give possibility for the npm cli and other automation tools to warn users when installed on the incompatible Node.js version:

{
  "name": "webdav",
  "version": "3.3.0",
  "engines": {
    "node": ">=10"
  }
}

More details can be found here: https://docs.npmjs.com/files/package.json#engines

@bponomarenko
Copy link
Author

Thanks for addressing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants