Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with hot-patcher at building a project #314

Closed
javilag opened this issue Aug 18, 2022 · 2 comments
Closed

Issue with hot-patcher at building a project #314

javilag opened this issue Aug 18, 2022 · 2 comments

Comments

@javilag
Copy link

javilag commented Aug 18, 2022

i'm trying to make a build with webdav but i'm finding the next error

"node_modules/webdav/dist/node/compat/patcher.d.ts:1:24 - error TS7016: Could not find a declaration file for module 'hot-patcher'. '.../node_modules/webdav/node_modules/hot-patcher/source/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/hot-patcher` if it exists or add a new declaration (.d.ts) file containing `declare module 'hot-patcher';`


1 import HotPatcher from "hot-patcher";

i'm using the strict mode in false and this error still happen.

@perry-mitchell
Copy link
Owner

Hi @javilag - I'm not sure what the issue is here, but it looks as though your configuration is trying to validate types in node_modules. I don't personally follow such a system, and hot patcher is not yet typescript. I plan to update it eventually but haven't yet had time.

It's best that you just ignore this for now by preventing Typescript from validating types in node modules. Try "skipLibCheck": true in tsconfig.json.

I'll close this as it's not an issue I plan to address as WebDAV works just fine.

@perry-mitchell
Copy link
Owner

This should be fixed by this incoming PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants