writeFile encoding has no effect any more

[fyears]

webdav-fs/source/adapter.ts

Line 190 in e00f56b

.putFileContents(filename, data /*{ format: encoding }*/)

Hi,

I forgot to mention an issue while I was refactoring webdav-fs to typescript.

I notice that writeFile, using putFileContents() from webdav-client, used to have encoding parameter.

However, the encoding option was removed from putFileContents().

Thus, I just kept the encoding parameter there to avoid changing end-user code. But actually it just "pass-through". And I do not have deep understanding about whether it's ok or not.

Is that an "expected change", or something that needs to be resolved?

[perry-mitchell]

Well, now that I look at it, I'm not sure if there's any change needed. webdav-fs is meant to somewhat mimic the standard fs interface of Node, and Node requires an encoding.