Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing click dependency #264

Closed
brancomat opened this issue Sep 26, 2022 · 3 comments
Closed

missing click dependency #264

brancomat opened this issue Sep 26, 2022 · 3 comments

Comments

@brancomat
Copy link

Hi,
this is more a proposal than a bug report.
Since python-rasterstats directly imports click:

and since there's a known issue with click<7.1 (#254) , adding a click>=7.1 in requirements.txt would be great.

The following is a real case scenario in which it would come in handy:

on a centos8/rocky8 server:

$ python3 -mvenv --system-site-packages env
$ env/bin/pip install rasterstats
# ... various logs ...

$ env/bin/python -c "import rasterstats"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/autofs/nfshomes/dbranchini/buttami/env/lib64/python3.6/site-packages/rasterstats/__init__.py", line 4, in <module>
    from rasterstats import cli
  File "/autofs/nfshomes/dbranchini/buttami/env/lib64/python3.6/site-packages/rasterstats/cli.py", line 28, in <module>
    @cligj.use_rs_opt
  File "/usr/lib/python3.6/site-packages/click/decorators.py", line 170, in decorator
    _param_memo(f, OptionClass(param_decls, **attrs))
  File "/usr/lib/python3.6/site-packages/click/core.py", line 1510, in __init__
    raise TypeError('Got secondary option for non boolean flag.')
TypeError: Got secondary option for non boolean flag.

(then after some googling I saw #254 and forced the update of click)

@jonathanqv
Copy link

I fixed this with pip install -U click

I also did the following, but you may not need it.

pip install -U requests cookiecutter

@JakobMiksch
Copy link

I had the same problem
pip install click fixed it for me as well

@perrygeo
Copy link
Owner

I can't reproduce this but, given we directly import click, it makes sense to include it as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants