Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP 500 status code properly in forms #26

Open
aapeliv opened this issue Nov 10, 2018 · 4 comments
Open

Handle HTTP 500 status code properly in forms #26

aapeliv opened this issue Nov 10, 2018 · 4 comments
Labels
bug Something isn't working requires API work Requires work on API
Projects

Comments

@aapeliv
Copy link
Collaborator

aapeliv commented Nov 10, 2018

No description provided.

@aapeliv aapeliv added the bug Something isn't working label Nov 10, 2018
@aapeliv aapeliv added this to To do in v0.2 via automation Nov 10, 2018
@shuttle1987
Copy link
Member

Is this upstream issue related to this: persephone-tools/persephone-web-API#64 ?

@aapeliv
Copy link
Collaborator Author

aapeliv commented Nov 11, 2018

Frontend should probably treat all errors in some meaningful way.

But standardising the error responses and not returning 500s upstream would be good (as spec says it doesn't return 500s).

@shuttle1987
Copy link
Member

If there's a 500 it's very likely a bug in the API, please open an issue if you encounter any such 500 errors.

@shuttle1987 shuttle1987 added the requires API work Requires work on API label Nov 12, 2018
@shuttle1987
Copy link
Member

I added an API for errors in persephone-tools/persephone-web-API#138, as is the case with 500 errors there's nowhere where I'm expecting to see them so it hasn't been specified just yet. Looks like an issue to open with the web API to specify the 500 error format in the API specification either as a 500 or in the default section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working requires API work Requires work on API
Projects
v0.2
  
To do
Development

No branches or pull requests

2 participants