Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update test verifyIranianNationalId.spec.ts #308

Conversation

geek-sajjad
Copy link
Contributor

Hi, when i run tests in the project i get this error :

 FAIL  test/verifyIranianNationalId.spec.ts > Validation of Iranian National Number(code-e Melli) > Check Truly inputs
AssertionError: expected false to not be falsy
 ❯ test/verifyIranianNationalId.spec.ts:31:52
     29|   expect(verifyIranianNationalId(787833770)).not.toBeFalsy();   
     30|   expect(verifyIranianNationalId(1583250689)).not.toBeFalsy();  
     31|   expect(verifyIranianNationalId("1111111111")).not.toBeFalsy();
       |                                                    ^
     32|   expect(verifyIranianNationalId("0499370899")).not.toBeFalsy();
     33|   expect(verifyIranianNationalId("0790419904")).not.toBeFalsy();

So i decided to create a PL for this.
thanks.

@ghost
Copy link

ghost commented Feb 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ali-master ali-master merged commit a4a3936 into persian-tools:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants