Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorter command names? (ngxensite / ngxdissite) #15

Open
Fedcomp opened this issue Sep 17, 2015 · 5 comments
Open

shorter command names? (ngxensite / ngxdissite) #15

Fedcomp opened this issue Sep 17, 2015 · 5 comments

Comments

@Fedcomp
Copy link

Fedcomp commented Sep 17, 2015

For example apache a2ensite is much shorter than nginx_ensite.
When i tried to change it manually (mv nginx_ensite ngxensite) i realized dissite is just a symlink and it's all hardcoded into one script.

So how about shorter command names? apache commands is really good because they are short, i see no reason to make long nginx_ensite, because this script mimics apache version (and apache commands are not intuitive in names), so it should be short as well, and not neccessary intuitive.

Or as compatibility support both variants.

@milabs
Copy link

milabs commented Oct 29, 2015

@Fedcomp Nice catch about the names. It would be nice to see something like nginx+ and nginx-

@Fedcomp
Copy link
Author

Fedcomp commented Oct 30, 2015

for my use in production, i already changed the name to ngensite/ngdissite, and it seems works without issues.

@milabs
Copy link

milabs commented Oct 30, 2015

@Fedcomp It's because of action matching string:

ACTION=$(echo $SCRIPTNAME | awk '$0 ~ /dissite/ {print "DISABLE"} $0 ~ /ensite/ {print "ENABLE"} $0 !~ /(dis|en)site/ {print "UNKNOWN"}')

https://github.com/perusio/nginx_ensite/blob/master/bin/nginx_ensite#L75

So, any command name that contains ensite and dissite is valid. Even a2ensite :-)

@Fedcomp
Copy link
Author

Fedcomp commented Oct 30, 2015

yeah i saw that. I would like however if it would be changed officially, or at least add additional symlinks.

@milabs
Copy link

milabs commented Oct 30, 2015

@Fedcomp Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants