Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tradingpair xrpeur #56

Closed
marionet opened this issue May 2, 2021 · 4 comments
Closed

tradingpair xrpeur #56

marionet opened this issue May 2, 2021 · 4 comments

Comments

@marionet
Copy link

marionet commented May 2, 2021

How can the tradingpair xrpeur be added?

@CosmicDuck
Copy link

CosmicDuck commented Mar 17, 2022

Simply add xrp and xrpeur to the existing values?

`


TRADING_PAIRS = ['btceur', 'bcheur', 'etheur', 'btgeur', 'bsveur', 'ltceur',
'xrpeur', 'iotabtc', 'dashbtc', 'gntbtc', 'ltcbtc']
ORDER_TYPES = ['buy', 'sell']
CURRENCIES = ['btc', 'bch', 'eth', 'btg', 'bsv', 'ltc',
'iota', 'dash', 'gnt', 'xrp']

`

Using showDeposits('xrp') is working.
showRates('xrpeur'), too.

@peshay
Copy link
Owner

peshay commented Mar 17, 2022

Can you create a PR for it, with a unit test and documentation about that function in the README?

@CosmicDuck
Copy link

Hello,

I see there is already an existing pull request which contains integration of xrp and doge in #58 additionally to ssl-verify warning pr. So I will not add more work for these issue.

@cj4c0b1
Copy link
Contributor

cj4c0b1 commented Sep 1, 2023

it's done on #59
we can close this.

@peshay peshay closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants