Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library Migration #30

Closed
siddhantrao23 opened this issue Aug 6, 2020 · 1 comment
Closed

Library Migration #30

siddhantrao23 opened this issue Aug 6, 2020 · 1 comment
Assignees
@Gituser143
Labels
enhancement New feature or request help wanted Extra attention is needed on-hold Issue on hold priority: medium

Comments

@siddhantrao23
Copy link
Contributor

siddhantrao23 commented Aug 6, 2020 •
edited

Is your request related to a problem? Please describe.
Running grofer on certain terminal dimensions causes the Network and Memory graphs to go past the widget borders. This is most likely a bug in termui, which is no longer maintained.

Describe the solution you'd like
Migrating to another library like termdash would be one possible solution, which has cleaner looking widgets and could prove to be better for future applications. Further discussion on compatibility and ease of migration is required. A new branch could be created for this migration.

Screenshots
issues

Desktop (please complete the following information):

  • OS: Kubuntu 18.04
  • Terminal: konsole 17.12.3
  • Go: 1.14.6
@siddhantrao23 siddhantrao23 added the enhancement New feature or request label Aug 6, 2020
@Gituser143 Gituser143 added help wanted Extra attention is needed priority: medium labels Aug 6, 2020
@Gituser143 Gituser143 self-assigned this Aug 6, 2020
@MadhavJivrajani MadhavJivrajani mentioned this issue Aug 6, 2020
Closed
3 tasks
@MadhavJivrajani
Copy link
Member

Refer #31

@MadhavJivrajani MadhavJivrajani added the on-hold Issue on hold label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gituser143 Gituser143

Labels
enhancement New feature or request help wanted Extra attention is needed on-hold Issue on hold priority: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadhavJivrajani @Gituser143 @siddhantrao23