Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listing of files #1967

Closed
nohwnd opened this issue Jun 2, 2021 · 3 comments
Closed

Remove listing of files #1967

nohwnd opened this issue Jun 2, 2021 · 3 comments
Milestone

Comments

@nohwnd
Copy link
Member

nohwnd commented Jun 2, 2021

StartMessage = "Executing all tests in '{0}'"

@ArmaanMcleod I think we should remove that output, it duplicates what is shown in the detailed view in discovery, and unlike the version it does not seem useful, because it is much easier to look at the discovery listing, instead of trying to decipher that list of files.

I think in the previous versions we printed the unresolved paths which made this more succinct, but it still was not very useful info, becaus most of the time it was just running all tests in '.'.

image

It also does not handle correctly when there are just scriptblocks executed, in that case it shows Executing all tests in '' and 1 scriptblock.

@nohwnd nohwnd added this to the 5.3 milestone Jun 2, 2021
@fflaten
Copy link
Collaborator

fflaten commented Jun 2, 2021

Sounds good. There's already an issue/discussion about the discovery itself being too noisy for some users, so this additional message listing 500+ testfiles might get unpopular 🙂

@ArmaanMcleod
Copy link
Contributor

ArmaanMcleod commented Jun 2, 2021

Hi @nohwnd and @fflaten, fully agree on this. I've submitted a PR which removes the start message completely with that "Executing all tests in..." line.

@nohwnd
Copy link
Member Author

nohwnd commented Jun 2, 2021

Fixed in #1968

@nohwnd nohwnd closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants