Add fallback startline #1678
Merged
Add fallback startline #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts extraction of re-run test in 459a4b7
nohwnd
reviewed
Sep 8, 2020
|
Great job! Btw do you have twitter? DM me there if you have, but DMs are open, and I can then mention you when tweeting releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. General summary of the pull request
#1664 changed the way StartLine in test/block-objects where detected to fix linefilter in scenarios where It/Context/Describe has the scriptblock-start on a different line than the function name. This added a requirement to specify a StartLine-parameter when using New-Test/Block directly which might break som custom solutions and makes RSpec-tests unnecessary complicated.
This PR adds a fallback to New-*Test/Block which ensure StartLine always has a value; either provided as a parameter or equal to the line where New-*Test/Block where called directly.
Fix #1673