Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename New-TestContainer to New-PesterContainer and fix Run.Container usage #1743

Merged
merged 7 commits into from
Oct 29, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Oct 28, 2020

PR Summary

Fixed passing container object via the Run.Container property on the configuration object by moving the functionality to the New-TestContainer function, and renaming that function to New-PesterContainer.

Fix #1737

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • All tests pass
    • Run ./build.ps1 -Clean; ./test.ps1 -NoBuild. Use a new PowerShell process when C# code is changed.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd
Copy link
Member Author

nohwnd commented Oct 28, 2020

@fflaten the "all tests pass" point in TODO seems unnecessary. I don't mind if people develop against our own CI builds. There is barely any traffic, and I rarely run all tests locally myself. Should we remove it?

@fflaten
Copy link
Collaborator

fflaten commented Oct 28, 2020

Wasn't sure about it myself, so added it just in case. Remove.

@nohwnd nohwnd changed the title Using container on config object Rename New-TestContainer to New-PesterContainer and fix Run.Container usage Oct 29, 2020
@nohwnd nohwnd merged commit 860513c into v5.0 Oct 29, 2020
@nohwnd nohwnd deleted the using-container-on-config-object branch October 29, 2020 12:35
@fflaten fflaten mentioned this pull request Oct 30, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametric script not working with configuration object
2 participants