Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Version-property in Pester4Result object #1789

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Nov 24, 2020

PR Summary

The Pester 4-compliant result-object returned from ConvertTo-Pester4Result includes a blank version-property and not 4.99.0 as expected. PR sets the value as string-type, just like the version-property in Pester5 result-object

Fix #1786

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd nohwnd merged commit 230e852 into pester:v5.0 Mar 8, 2021
@fflaten fflaten deleted the pester4result-fix branch March 8, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConvertTo-Pester4Result output missing Version
2 participants