Add assembly version check during module import #1790
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
build.ps1
Outdated
| if ($Clean) { | ||
| $content += @( | ||
| $manifest = Test-ModuleManifest -Path "$PSScriptRoot/bin/Pester.psd1" |
There was a problem hiding this comment.
This fails on PS3 with "The wildcard is incorrect"
There was a problem hiding this comment.
Well that was weird. Looks like Test-ModuleManifest invoked Import-Dependency for some absurd reason. 😕
Stacktrace?
There was a problem hiding this comment.
I don't have any, I can only see it not fail when running on ps7.
There was a problem hiding this comment.
Reverted to PS3 build with (ugly) workaround in case PS3 build is still required. If it's okay to use PS7 for build then we should use Test-ModuleManifest again.
The PS7/vs2019 run only failed due to the psversion-output commit. It made passthru object $r from p-tests become arrays which broke the if failed-check after.
There was a problem hiding this comment.
We can build on ps7, but I would keep both approaches in case I need to debug something specifically on PS3. Thx. And thanks for helping here, I had no idea what was happening. 🙂
|
Other than the nitpick and the possible reversal to use ps7 for build this is imho good to go. I am also okay with keeping it PS3 compatible and building with the existing setup. If nothing the build will be slightly faster because it is on a deployed agent, and not on a shared (hosted) agent. |
Co-authored-by: Jakub Jareš <me@jakubjares.com>
PR Summary
PowerShell (.NET) doesn't allow loading different version of the same assembly in a process/appdomain. This can give the user a non-terminating error if they import different versions of Pester in the same PowerShell-session. Usually the error can be ignored, but some versions of the Pester module can require changes in the assembly and the user might see weird errors as a result.
The PR adds a minimum assembly version-check during import of the assembly. The requirement is stored as value in the manifest. If the user has the same or newer (until this idea breaks) assembly loaded, the assembly will not be loaded again during import. If the version is older than the requirement, an exception will be thrown to stop the module import, warning about the conflict. Else, import as normal (current behavior).
Fix #1770
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.