Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NUnit2.5 option #1796

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Fix NUnit2.5 option #1796

merged 3 commits into from
Dec 6, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Dec 1, 2020

Fix #1794

@nohwnd nohwnd requested a review from fflaten December 1, 2020 17:28
@nohwnd nohwnd added this to the 5.1.1xx milestone Dec 1, 2020
@nohwnd
Copy link
Member Author

nohwnd commented Dec 1, 2020

/fyi @asears

fflaten
fflaten approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@fflaten fflaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it worth looking into input-validation for e.g. OutputFormat in the configuration-object (in a new issue)? To break early like we do with ValidateSet in the legacy-parameter.

src/csharp/Pester/Configuration.cs Outdated Show resolved Hide resolved
@asears
Copy link
Contributor

asears commented Dec 1, 2020

I've switched to new NUnitXml format in pipelines we're using and will leave that as-is.

@nohwnd @fflaten
Update src/csharp/Pester/Configuration.cs
f1a780c 
Co-authored-by: Frode Flaten <3436158+fflaten@users.noreply.github.com>
@nohwnd
Copy link
Member Author

nohwnd commented Dec 2, 2020

Looks good. Is it worth looking into input-validation for e.g. OutputFormat in the configuration-object (in a new issue)? To break early like we do with ValidateSet in the legacy-parameter.

Yes, I intended to do that, but it is not high on my priority list.

@nohwnd
Copy link
Member Author

nohwnd commented Dec 2, 2020

I've switched to new NUnitXml format in pipelines we're using and will leave that as-is.

Would you expect that to upgrade automatically to NUnit3 once we implement it?

@nohwnd
Copy link
Member Author

nohwnd commented Dec 6, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd merged commit 309d352 into rel/5.1.1xx Dec 6, 2020
@nohwnd nohwnd deleted the fix-nunit-25 branch December 6, 2020 07:20
@nohwnd nohwnd mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fflaten fflaten fflaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.1xx
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nohwnd @asears @fflaten