Build locally without inlining #1872
Conversation
For a while I've been inlining the whole script into one module but debugging and changing the code is difficult that way, because changes need to be done in the respective file, not Pester.psm1. Investigating how to just dot-source when building locally
|
At the moment the biggest issue is that module Pester.Runtime.psm1 is changed to be just .ps1 script, which makes strict mode apply to it from the tests where we import the file directly. There are many places where I did not consider strict mode, and so many tests are failing. I will probably just disable the strict mode in tests, because it does not do what we thought it does, and pursuit having the code strict in a different milestone. It's useful, but not more useful than having the dot-sourcing / inlining build. |
|
@fflaten I guess you are making a bit of changes on Pester, so you might like this. No more doing changes just to have them overwritten on build, or setting breakpoints in the source file and never have it hit... |
|
I've stopped modifying the src-files a long time ago. All dev and debug directly in bin/Pester.psm1 with git stash as archive 😄 |
|
There is basically nothing to it. I just dot-source the files (almost) as I did originally. And only inline the code when releasing or in CI. There are few fixes needed to make this work, like when we are omitting lines from errors that belong to pester, or when importing dlls relative to the current file path. And also all the dependency modules became script files, because otherwise there was a ton of problems with variables that are inherited from parent that were not inherited due to Pester.Runtime being a module. On the other hand making it non-module had big impact on Pester.Runtime tests, because then all the code run in the same session state, which led to a lot of conflicts. So I just dot source it into a module in the test. |
| $path = "$PSScriptRoot/bin/netstandard2.0/Pester.dll" | ||
| if ((Get-Variable -Name "PESTER_BUILD" -ValueOnly -ErrorAction Ignore)) { | ||
| $path = "$PSScriptRoot/../bin/bin/netstandard2.0/Pester.dll" | ||
| } | ||
| else { | ||
| $path = "$PSScriptRoot/../bin/bin/netstandard2.0/Pester.dll" | ||
| } # endif | ||
| & $SafeCommands['Add-Type'] -Path $path | ||
| } | ||
| else { | ||
| & $SafeCommands['Add-Type'] -Path "$PSScriptRoot/bin/net452/Pester.dll" | ||
| $path = "$PSScriptRoot/bin/net452/Pester.dll" | ||
| if ((Get-Variable -Name "PESTER_BUILD" -ValueOnly -ErrorAction Ignore)) { | ||
| $path = "$PSScriptRoot/../bin/bin/net452/Pester.dll" | ||
| } | ||
| else { | ||
| $path = "$PSScriptRoot/../bin/bin/net452/Pester.dll" | ||
| } # endif | ||
| & $SafeCommands['Add-Type'] -Path $path |
There was a problem hiding this comment.
quick follow-up: what is the idea with the inner else-blocks (L6-L8 and L16-18)?
For a while I've been inlining the whole script into one module but debugging and changing the code is difficult that way, because changes need to be done in the respective file, not Pester.psm1. Investigating how to just dot-source when building locally.