Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in all files #1949

Merged
merged 2 commits into from May 17, 2021
Merged

Fix formatting in all files #1949

merged 2 commits into from May 17, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented May 17, 2021

Fixed formatting in all files and fixed tests that rely on formatting

@@ -95,7 +95,7 @@
# It's for rebuilding PowerShellGet (and PoshCode) NuGet-style packages
# We had to do this because it's the only place we're allowed to extend the manifest
# https://connect.microsoft.com/PowerShell/feedback/details/421837
PSData = @{
PSData = @{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PSD1 formatting of hashtables is weird, but I am okay with that.

Comment on lines 1 to 8
@{
Severity = @('Error','Warning')
Severity = @('Error', 'Warning')
IncludeDefaultRules = $true
CustomRulePath = './Pester.BuildAnalyzerRules'
ExcludeRules=@(
CustomRulePath = './Pester.BuildAnalyzerRules'
ExcludeRules = @(
'PSUseShouldProcessForStateChangingFunctions'
'PSUseApprovedVerbs'
'Measure-SafeCommands'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. PSD1 formatting sucks.

@nohwnd
Copy link
Member Author

nohwnd commented May 17, 2021

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@fflaten
Copy link
Collaborator

fflaten commented May 17, 2021

Since we're enabling format on save here, should we standardize on UTF8-bom encoding for ps1/psm1 files at the same time? Related #1747

With BOM due to Windows PowerShell versions.

@nohwnd
Copy link
Member Author

nohwnd commented May 17, 2021

Sure. Moving discussion to the issue.

@nohwnd nohwnd merged commit 52067e0 into v5.0 May 17, 2021
@nohwnd nohwnd deleted the format-all branch May 17, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants