Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use profiler to improve perf of test drive, name expanding and add-member #1955

Merged
merged 10 commits into from May 20, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented May 20, 2021

No description provided.

@nohwnd
Copy link
Member Author

nohwnd commented May 20, 2021

image

This is how it looks after the changes, can't change those pieces without disabling TestDrive. I also think I changed the described behavior of test drive to setup new one for each top-level describe as it was in v4. Will revert that to the described behavior of one test drive per file.

@nohwnd
Copy link
Member Author

nohwnd commented May 20, 2021

Reverted that was easier than expected. And TestDrive no longer shows up that much:

image

@nohwnd nohwnd merged commit 0fe8359 into v5.0 May 20, 2021
@nohwnd nohwnd deleted the perf branch May 20, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant