New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSObject boxing support in PesterConfiguration #1978
Add PSObject boxing support in PesterConfiguration #1978
Conversation
Bear with me a bit, fixing. |
Made it a Draft PR, mark it as ready for review when done. |
I was going to pull out the deserializer code I've written, but instead I've changed it so it's only available to PS 5 and higher. It can, of course, be culled if it's not appropriate. I wanted to rewrite it into C#, but it was giving me such a hard time, death by reflection. I'll add some tests in the morning. It'll be interesting to see how the large scale test run works out. A lot of the failures I saw locally are speculatively nothing to do with me :) |
Yeah, we need to solve this for PS3 and up. I think the same thing happens when you pass the values via |
I'll have another crack at the C# version. It's going to be horrible ;) |
Just a brief note on this version. I still use the I found when I used the Types file that the assembly implementing the deserializer had to be loaded before the root module (for psm1) which may have worked if it were possible to require the assembly in the manifest, but not otherwise. Anyway, it's all compatible with PS 3 now, or at least it is if the test results are accurate :) |
PR Summary
Fixes #1977
GetIDictionaryOrNull
extension method.PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.