Block direct modification of Value-property in configuration options #1994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Makes the setter of Value-property in configuration options private. This is done because modifying
Value
directly won't flip the internal_isOriginalValue
-flag used to detect whether a user has modified the option. This is important to know which values to override when merging configuration.Fix #1971
Possible breaking change: Users may create their advanced configurations by modifying Value directly because it has been possible or because it can be easier in certain scenarios, ex.
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.