Set name in xml element testsuite

[Marc013]

PR Summary

Fixes #2033

Pester configuration 'TestResult.TestSuiteName' sets name in element 'test-results' instead of name in first element 'test-suite'

[nohwnd]

Please add a test for this so we avoid regressions.

[fflaten]

You can merge this if you want. -Path is used for name and description IIRC.

[Marc013]

@nohwnd
I would love to make a unit test however, I have no clue how I can unit test the change I have implemented in function ‘Write-NUnitTestResultChildNodes’.
Can you provide any help/guidance here?

[nohwnd]

There are tests for this feature NUnit output in https://github.com/pester/Pester/blob/main/tst/Pester.RSpec.Nunit.TestResults.ts.ps1 those are P tests, P is simplified test framework that we use to test some aspects of Pester. You should be able to simply run the whole file. If that does not work run .\test.ps1 from the root of the repo first.

In that file you add a test, they use i, b and t functions, i is for invoke, b is for block (like Describe in Pester) and t is for test (like It in Pester). You can focus a single test by using dt instead of t to make development easier. Hopefully reading few other tests in the file will make it clear what is happening. You run a Pester run, and then compare the resulting XML to ensure it was produced correctly.

[Marc013]

@nohwnd,
The unit test is added. I hope it's to your satisfaction.

[fflaten]

Thanks @Marc013 . I made a few adjustments to clean up the "RunResult"-parameters + simplified the test. Also, didn't want to scare any DC-fans from contributing 😄