Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord-link and cleanup README #2102

Merged
merged 5 commits into from Apr 22, 2022
Merged

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Nov 7, 2021

PR Summary

A little cleanup of README

  • Updates a few broken links
  • Adds a Discord-link under got questions
  • Remove duplicate images
  • Update logo URLs in nuspec and psd1
  • Move Examples?

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten
Copy link
Collaborator Author

fflaten commented Nov 7, 2021

  • Remove duplicate images?
  • Move Examples?

@nohwnd Any thoughts on the docs-folder in the repo? You placed examples and images subfolders in it during 5.0 dev, but later added the same images (mostly) to /images while updating the README.

Should I update README to use docs/images paths and merge/remove the /images on root? Or move examples to root and delete docs?

@nohwnd
Copy link
Member

nohwnd commented Apr 12, 2022

I guess I wanted to have docs in separate folder but then we created a whole new docs repo. I think images in root should stay.

@fflaten fflaten marked this pull request as ready for review April 17, 2022 16:03
@nohwnd nohwnd merged commit 4370ecc into pester:main Apr 22, 2022
@fflaten fflaten deleted the update-readme branch April 22, 2022 22:52
@fflaten fflaten restored the update-readme branch April 23, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants