Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container failure output #2167

Merged
merged 1 commit into from Apr 29, 2022
Merged

Fix container failure output #2167

merged 1 commit into from Apr 29, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Apr 29, 2022

PR Summary

When container fails, the parameters were not splatted correctly which ends up failing when there are more than 1 errors.

When we capture an error that has not stack trace, like when Import-Module is called directly in the body of test, for module that is missing, we would append new line to the resulting error. This will fail the mandatory parameter validation for Format CI message, and throw.

I removed appending the new line, and relaxed the parameter rule, because I don't think writing the error should fail when it has a format that is little bit unexpected.

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd nohwnd merged commit c79a6fa into main Apr 29, 2022
@nohwnd nohwnd deleted the fix-container-failure-output branch April 29, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant