Allow native PHP functions to not be used

[jbrooksuk]

Given the following architecture test:

test('globals')
    ->expect(['sleep', 'usleep'])
    ->not->toBeUsed();

I'd expect it to fail in this file:

<?php

namespace App\Jobs;

class JobWithSleep
{
    public function handle()
    {
        sleep(10);
    }
}

But it doesn't, as Pest considers these native functions.

[fabio-ivona]

@nunomaduro it seems that the issue is related to https://github.com/ta-tikoma/phpunit-architecture-test

as DependenciesAsserts::assertDoesNotDependOn() is called correctly from pest arch plugin by passing a layerA containing all project classes and a layerB containing a sleep FunctionDescription:

I'm further investigating why it doesn't detect the function usage, will update this thread soon

Update: it seems the issue is related to how ObjectDescription::uses is built, as it does include standard functions but skips built-in ones

Update: the issue depends on how Pest Arch Plugin builds the layer that is passed to DependenciesAsserts, see following comment for more info

[fabio-ivona]

@nunomaduro I found where the issue is generated:

in ObjectDescriptionFactory.php#L52 the layer uses is filtered by removing all items that are not user-defined (so, basically, it removes all built-in functions):

by removing self::isUserDefined($use) statement, built-in functions are detected

 if (! $isFromVendor) {
      $object->uses = new ObjectUses(array_values(
          array_filter(
              iterator_to_array($object->uses->getIterator()),
-              static fn (string $use): bool => self::isUserDefined($use) && ! self::isSameLayer($object, $use),
+              static fn (string $use): bool =>  ! self::isSameLayer($object, $use),
          )
      ));
  }

[fabio-ivona]

@nunomaduro before opening a PR to fix this, I'm wondering why you added self::isUserDefined($use)

any idea?

[devajmeireles]

Hey, @jbrooksuk . Thanks for your feedback.

I'm checking with Pest team if we have plans to do that. I'll update this issue soon.

[fabio-ivona]

@devajmeireles I have a working implementation for this, will clean it up and open a PR soon

[fabio-ivona]

a fix is proposed in pestphp/pest-plugin-arch#4