Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join forces #3

Open
peta opened this issue Apr 30, 2013 · 4 comments
Open

Join forces #3

peta opened this issue Apr 30, 2013 · 4 comments

Comments

@peta
Copy link
Owner

peta commented Apr 30, 2013

Hello everybody,

quite some time passed since the last changes to redis-natives-py. To be honest, Python hasn't been a substantial part of my language stack for the last two yrs or so (and I believe that it will neither in the near future), that's why I didn't come up with new changes/additions/fixes to redis-natives-py by myself.

But the project network graph shows that there are several forks that diverged with several commits that seem to be worth being integrated back into the main repository. (Especially @kvesteri commited a bunch of changes.)

Redis and the equally named Python client module have changed over the time and are supposed to do so in the near future. In order to keep redis-natives-py up to date and thus also useful for other python devs, I had the idea to join forces. What do you think about becoming maintainers to the official redis-natives-py repository, so that you can work directly on the sources and have full control?

Another question is, whether you are still using redis-natives-py and if you still consider it being useful and worth enough maintining it. Does anybody have experience about how it works with Python3?

I'd be glad to hear from you.

Peter

peta referenced this issue in srj55/redis-natives-py Apr 30, 2013
also fixed __eq__ so that when a Primitive is a number X, it will return true when compared to both x and 'x'
peta referenced this issue in kvesteri/redis-natives-py Apr 30, 2013
@kvesteri
Copy link
Collaborator

kvesteri commented May 1, 2013

Our company (www.fastmonkeys.com) is using python only and we have currently one major project where we are using redis-natives-py. I really like the idea behind the API and think this project is very useful. If possible I could take a maintainer role.

@peta
Copy link
Owner Author

peta commented May 1, 2013

@kvesteri Very cool. Welcome in the club! ;-)

@kvesteri
Copy link
Collaborator

kvesteri commented May 1, 2013

Couple of things I've done in my fork are:

  • Tests for all datatypes
  • All complex operations (for example symmetric difference etc) done in redis side instead of python side (much more efficient)
  • Variables named in more pythonic way (for example redis_keys instead of redisKeys)
  • Fixed lots of bugs in all datatypes

If you think these changes are good we good start by merging them?

@peta
Copy link
Owner Author

peta commented May 1, 2013

@kvesteri I've seen your commits. That was the actual reason I came up with this idea ... would've been a pity when the main repository didn't include these. (and the contributions of other forks also)

I just added you to the list of project maintainers. Would you please check if you have sufficient access privileges to the project? (write access to git, being able to edit issues asf.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants