Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Logic in AkkaPersistenceLivenessProbe #49

Closed
Zetanova opened this issue Jan 4, 2020 · 0 comments · Fixed by #162
Closed

Missing Logic in AkkaPersistenceLivenessProbe #49

Zetanova opened this issue Jan 4, 2020 · 0 comments · Fixed by #162

Comments

@Zetanova
Copy link

Zetanova commented Jan 4, 2020

The SuicideProbe class is to check the persistence journal state.
It recovers the last event and snapshot from the journal
After it writes a new event and snapshot to the journal
and deletes all old events and snapshots.

The issue is that it already send a RecoveryStatus on successful revoery back
without checking the success of the new persistet event or snapshot

And in the case when the journal success in only recovery (read-mode) and not in persist (write-mode)
then the RecoveryStatus will still be always successful.

The bottom line is that the write and the delete of new "hit" messages is somehow
not used by the healthcheck itself and only makes a hit on one sector of the SSD every 10sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant