Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2nd warmup run appears to never collect any metrics #67

Closed
Aaronontheweb opened this issue Dec 16, 2015 · 0 comments 路 Fixed by #86
Closed

2nd warmup run appears to never collect any metrics #67

Aaronontheweb opened this issue Dec 16, 2015 · 0 comments 路 Fixed by #86
Labels
bug

Comments

@Aaronontheweb
Copy link
Member

Looks like we have some sort of N+1 error inside the warmup system for Benchmark that causes the first actual warmup after the pre-warmup to not actually collect any metrics. Whoops 馃槰
Aaronontheweb added a commit to Aaronontheweb/NBench that referenced this issue Mar 19, 2016
@Aaronontheweb
close petabridge#67 - fixed warmup with no numbers issue
90a3c1b
Aaronontheweb added a commit to Aaronontheweb/NBench that referenced this issue Mar 20, 2016
@Aaronontheweb
created MeasurementConfigurator<T>
84eea83 
finished implementing configurator searching within ReflectionDiscovery
refactored the internals of BenchmarkSettings and ReflectionDiscovery to use configurators
close petabridge#67 - fixed warmup with no numbers issue
close petabridge#61 Added NBench.PerformanceCounters
@Aaronontheweb Aaronontheweb mentioned this issue Mar 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented plugin model; NBench.PerformanceCounters Aaronontheweb/NBench
1 participant
@Aaronontheweb