Added iterator functions without channels and goroutines. #8
Conversation
| return false | ||
| } | ||
| } | ||
| if !t.eachInOrder(h.Right, lower, iterator) { |
There was a problem hiding this comment.
replace with "return t.eachInOrer(..."
|
Ah there, better? :) |
|
Yeah, I'll get back to pulling this in a day or two. Quite busy Thanks On 4 July 2012 16:20, zond
|
|
Excellent, no hurry :) |
|
OK, so I rewrote your code a little. Some cosmetic renames, comments and simplified your conditional block structure. Take a look at it. See if you like it. Tell me how you want to be listed in the AUTHORS file. |
|
Ah, excellent! No sweat, I just wanted those iterators - I find them cheaper than creating channels and goroutines. If you want to you can add "Martin Bruse" as author, but it doesn't really matter to me, I really just wanted the iterators :) |
Since I want to wrap this tree in sync.RWMutex and use in a thread safe way, I would much prefer the submitted form of iterators. Would it be ok to accept that in your project, or should I stick with a fork?
regards,
//Martin