Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigmoid function is missing in layers/discriminator.py #6

Closed
liangxun opened this issue Apr 29, 2019 · 1 comment
Closed

sigmoid function is missing in layers/discriminator.py #6

liangxun opened this issue Apr 29, 2019 · 1 comment

Comments

@liangxun
Copy link

It seems that the sigmoid function is missing in layers/discriminator.py[line30].
Explained in your paper, the logistic sigmoid nonlinearity is used to convert scores into probabilities of (h_i, s) being a positive example.

@PetarV-
Copy link
Owner

PetarV- commented Apr 29, 2019

Hello,

Thanks for your issue. The sigmoidal function is (implicitly) applied by the BCEWithLogitsLoss as used here:
https://github.com/PetarV-/DGI/blob/master/execute.py#L60

Working with raw inputs allows for some numerical tricks to make the computation more stable.

Thanks,
Petar

@PetarV- PetarV- closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants