Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing extensions for some common types #456

Closed
Tux opened this issue Apr 30, 2014 · 6 comments
Closed

Missing extensions for some common types #456

Tux opened this issue Apr 30, 2014 · 6 comments
Labels
Milestone

Comments

@Tux
Copy link

Tux commented Apr 30, 2014

My .ackrc contains (local (color) stuff stripped)

--8<---
--type-add=html:ext:xhtml
--type-add=xml:exe:xsd,wsdl

--ignore-directory=is:target
-->8---

.xhtml is an extension that I encounter quite often and does not show up under --dump. IMHO it should be added to html

.xsd and .wsdl are very clearly subject to the xml group and IMHO should be added to the default list of extensions for XML

the folder "target" should be skipped in netbeans/eclipse/maven project folders. Maybe only if the same folder exists with /src/ where the found folder has /target/

@petdance
Copy link
Collaborator

Certainly target is too broad a target to skip. The other ones probably make sense, but I leave it open to commentary for now.

@Tux
Copy link
Author

Tux commented Apr 30, 2014

that is why I explained the target rule. I however found no way to skip target if and only if the same dir existed as src

@petdance
Copy link
Collaborator

no way to skip target if and only if the same dir existed as src

That's right, there is no way.

@Tux
Copy link
Author

Tux commented Apr 30, 2014

thanks for the feedback

@hoelzro hoelzro added this to the Maybe milestone Sep 3, 2014
@petdance
Copy link
Collaborator

petdance commented Jun 9, 2016

.xsd has been added elsewhere.

petdance added a commit that referenced this issue Mar 16, 2017
Added .xhtml to the --html filetype.  Added .wsdl to the --xml filetype.
Thanks, H.Merijn Brand.  (GH #456)
@petdance
Copy link
Collaborator

Done in eed2c4f. This will go out in 2.17_01. Thanks.

@petdance petdance modified the milestones: 2.18, Maybe Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants