doc-tag-required errors are now sorted by tag name.

petdance · Apr 7, 2015 · f5115c7 · f5115c7
1 parent cdf1ac1
commit f5115c7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -6,6 +6,15 @@ NOTE: All bugs and requests are now being handled through GitHub.
 
 Please DO NOT send bug reports to http://rt.cpan.org/.
 
+NEXT
+
+    [FIXES]
+    Errors of the type doc-tag-required did not come out in any defined
+    order.  They are now sorted by tag name.  This was discovered
+    because hash randomization caused tests to fail on Perl 5.18 and
+    above. Thanks, Slaven Rezic and Andrew Main.
+
+
 2.22    Mon Apr  6 15:47:11 CDT 2015
     [CHANGES THAT COULD BREAK YOUR CODE]
     Previously, html_ok() would not check the entire structure of a web

diff --git a/lib/HTML/Lint/Parser.pm b/lib/HTML/Lint/Parser.pm
@@ -102,7 +102,7 @@ sub _start_document {
 sub _end_document {
     my ($self,$line,$column) = @_;
 
-    for my $tag ( keys %isRequired ) {
+    for my $tag ( sort keys %isRequired ) {
         if ( !$self->{_first_seen}->{$tag} ) {
             $self->gripe( 'doc-tag-required', tag => $tag );
         }