Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should be disabled if config.puppet_install.puppet_version is not present #7

Closed
tknerr opened this issue Jul 29, 2014 · 5 comments

Comments

@tknerr
Copy link

tknerr commented Jul 29, 2014

Right now the plugin seems to be active even there is no config.puppet_install.puppet_version in my Vagrantfile.

I noticed it while I was more or less offline and got this error message from a totally puppet unrelated Vagrantfile:

Y:\tmp\vagrant-cachier-centos-bug>vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Puppet Install Plugin:
* '' is not a valid version of Puppet.

A list of valid versions can be found at: http://docs.puppetlabs.com/release_notes/
@petems
Copy link
Owner

petems commented Jul 29, 2014

Interesting...

Yeah, it will show that error if you're not connected, but only if the puppet_install.puppet_version value is present...

Can you show me the Vagrantfile you're using?

@tknerr
Copy link
Author

tknerr commented Jul 29, 2014

I thought so too... :-)

This is the Vagrantfile:

Vagrant.configure("2") do |config|
  config.vm.box = "chef/centos-6.5"
end

Just disconnect from the network and run vagrant up, you will get the above error.

@petems
Copy link
Owner

petems commented Jul 29, 2014

Weird, I'll have to double check that then! 👍

@petems
Copy link
Owner

petems commented Aug 3, 2014

@tknerr I think I've actually fixed this in the newest version of the plugin! Can you try updating and trying running a vagrant box without an internet connection? I can replicate it the version of the plugin I have running on my machine, but not the version in the repo

@tknerr
Copy link
Author

tknerr commented Aug 3, 2014

Yep, verified that it works as expected with version 2.5.0 👍

Thanks!

@tknerr tknerr closed this as completed Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants