Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Publish to npm #317

Closed
dr3 opened this issue Feb 25, 2024 · 2 comments
Closed

Feature Request: Publish to npm #317

dr3 opened this issue Feb 25, 2024 · 2 comments

Comments

@dr3
Copy link

dr3 commented Feb 25, 2024

Thanks for great repo!

I have a custom JS action where I want to have commenting functionality, would you consider publishing this repo to NPM?

That way I can call createOrUpdateComment util function directly, rather than having to push values to the env before commenting via the action

Happy to publish a fork myself if you dont want to, but of course would prefer you retained the control over it!

@peter-evans
Copy link
Owner

Hi @dr3

Not sure if I want to support using this as a library. It would likely need some refactoring to make it work nicely, plus some custom packaging to remove main.ts and the main() call.

My suggestion would be to go ahead and make the fork. Once you have it working, if you show me the fork I'll take a look at the changes and see if I want to make them here and support it. What do you think?

@dr3
Copy link
Author

dr3 commented Feb 26, 2024

Thats fair @peter-evans!

On reflection I think npm publishing would be useful with the addition of a method to find comment with matching identifier, if exists edit/delete, else create. However for now I think best to close this issue, cheers though!

@dr3 dr3 closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants