Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git -c core.pager=cat diff #626

Closed
frassinier opened this issue Nov 16, 2020 · 5 comments · Fixed by #627
Closed

git -c core.pager=cat diff #626

frassinier opened this issue Nov 16, 2020 · 5 comments · Fixed by #627

Comments

@frassinier
Copy link

Subject of the issue

I used this action to update a lot of files, but I saw that a Create or update the pull request branch can be very long!
Especially with a huge amount of files!

I'm wondering why do we need this?
https://github.com/peter-evans/create-pull-request/blob/master/src/git-command-manager.ts#L100

It results in a lot of not useful logs.

Steps to reproduce

Try to push a big amount of files 🤷

@peter-evans
Copy link
Owner

Hi @frassinier

can be very long

Do you mean the action takes a long time to complete? Please let me know roughly how many files were in the pull request and how long the action took to complete.

That particular git command is used in a couple of places, but the main use is to detect if the local repository is "dirty."
https://github.com/peter-evans/create-pull-request/blob/master/src/git-command-manager.ts#L156-L171

If the verbosity of that particular command is causing the action to not perform well I will take a look at improving it.

@frassinier
Copy link
Author

Thank you for your quick answer,

Indeed, the action takes too long for +300 files.
I used it for copying a lot of JS and CSS files, and it takes more than 30min showing files content. During this time, the action is blocked.
I finally cancelled the job since it was quite weird to see "create pull request" being so long 🤨

@peter-evans
Copy link
Owner

@frassinier I've released a new version of the action (v3.5.0/v3) with improvements to tackle this issue.

@peter-evans
Copy link
Owner

Thanks for reporting!

@frassinier
Copy link
Author

LGTM, thank you! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants