Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing API for Add/Update Organization Membership #238

Closed
bdevore opened this issue Sep 4, 2015 · 2 comments
Closed

Missing API for Add/Update Organization Membership #238

bdevore opened this issue Sep 4, 2015 · 2 comments

Comments

@bdevore
Copy link

bdevore commented Sep 4, 2015

Hey, we're trying to use your API to work with our Enterprise Github installation and noticed that the following GitHub API method isn't included yet: https://developer.github.com/v3/orgs/members/#add-or-update-organization-membership. I'm fairly to Ruby, but took a whirl at adding the method call to your API. I can send in a PR with my change, it was fairly minor.
@piotrmurach
Copy link
Owner

As it appears all the member memberships endpoints are not implemented. You should be able to reproduce the current logic to add this and other endpoints to the library. In order for me to merge the PR it would need to include tests. For inspiration, you should find plenty test examples already in features and specs directories. Looking forward to reviewing.

Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 3, 2015
@Shwetakale
Added API for Add/Update Organization Membership. Refs[piotrmurach#238]
37a3e4a
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 3, 2015
@Shwetakale
Added API for Add/Update Organization Membership. Refs[piotrmurach#238]
2b081f9
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 4, 2015
@Shwetakale
Added API for Add/Update Organization Membership. Refs[piotrmurach#238]
453e16e
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 7, 2015
@Shwetakale
Minor change in cassetters[piotrmurach#238]
3eaa874
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 10, 2015
@Shwetakale
Pass params to stub request[piotrmurach#238]
05000d4
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 14, 2015
@Shwetakale
Pass params to stub request[piotrmurach#238]
8ee1dbc
Shwetakale added a commit to joshsoftware/github that referenced this issue Oct 14, 2015
@Shwetakale
Pass params to stub request[piotrmurach#238]
d0a4807
piotrmurach added a commit that referenced this issue Nov 21, 2015
@piotrmurach
Merge pull request #242 from joshsoftware/issue_238
be335ae 
Added API for Add/Update Organization Membership. Refs[#238]
@piotrmurach
Copy link
Owner

Part of v0.13.0 release. Try using the following:

github = Github.new oauth_token: 'abc....'
github.orgs.memberships.add 'org-name', 'member-name', role: 'role'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piotrmurach @bdevore