Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API for Add/Update Organization Membership. Refs[#238] #242

Merged
merged 3 commits into from
Nov 21, 2015

Conversation

Shwetakale
Copy link
Contributor

    github = Github.new oauth_token: '...'
    github.orgs.members.grant_organization_membership 'org-name', 'member-name', {role: 'role'}
  • role is optional and can be member / admin. default - member

@Shwetakale
Copy link
Contributor Author

@peter-murach I added my credentials while testing this API locally to generate cassettes and they are passing locally but travis is failing.

What should I do to pass this build on travis?

@phoet
Copy link

phoet commented Oct 7, 2015

@Shwetakale thx for implementing this.

i think you made a small mistake where <BASIC_AUTH> should be https://<BASIC_AUTH> in the first casette.

@Shwetakale
Copy link
Contributor Author

@phoet Yup looks like. Thanks updated this PR :).

@phoet
Copy link

phoet commented Oct 14, 2015

@Shwetakale there is a test failing just for the jruby test-suite. i'm assuming that there is an issue with the order of let and before in the grant_organization_membership_spec.rb.

i'd try moving the mock-request calls down into the describe blocks. there is also a after { reset_authentication_for(subject) } in the other spec files. don't know exactly if that is of interest here.

@Shwetakale
Copy link
Contributor Author

@phoet Thanks. You are right Test case is only failing for JRuby and I don't think any issue of let and before filter. Will need to test it on JRuby.

piotrmurach added a commit that referenced this pull request Nov 21, 2015
Added API for Add/Update Organization Membership. Refs[#238]
@piotrmurach piotrmurach merged commit be335ae into piotrmurach:master Nov 21, 2015
@piotrmurach
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants