Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACK Queue: readme example for SQLiteAckQueue missing clear_acked_data() #77

Closed
employee-1234567 opened this issue Nov 21, 2018 · 4 comments
Labels
doc documentation only

Comments

@employee-1234567
Copy link

Unless I'm missing something, it seems the ACKQueue does not clean up after its self when you ACK the items. I discovered this function by looking over the unit tests. Is it expected that users call this function manually? It seems that clear_acked_data() should always be called after ackq.ack(item) if you don't want the sqlite DB to grow unbounded?

@peter-wangxu
Copy link
Owner

Looks like dup of #78

@employee-1234567
Copy link
Author

I filed these as separate issues as I see this as a documentation issue. Basically, what this issue is asking is "do you expect users to explicitly call clear_acked_data()?" If so it should be added to the example in the readme and not left for someone to accidentally find it buried in the unit tests

@dcj
Copy link

dcj commented Dec 10, 2018

Yes, I have this same question, should users explicitly call clear_acked_data(), and if so, when/how often?

@peter-wangxu peter-wangxu added the doc documentation only label Dec 16, 2018
@peter-wangxu
Copy link
Owner

please check it out in latest doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc documentation only
Projects
None yet
Development

No branches or pull requests

3 participants