you don't need to fix closing tags with method='html'

peterbe · Mar 6, 2013 · 9b7039a · 9b7039a
1 parent 75c1e90
commit 9b7039a
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/proxy/app.py b/proxy/app.py
@@ -196,14 +196,7 @@ def css_url_replacer(match, href=None):
                 collect_stats
             )
 
-    html = etree.tostring(page)
+    html = etree.tostring(page, method='html')
-    # the etree.tostring() method will turn `<script src="foo"></script>'
-    # to `<script src="foo"/>`. Fix that.
-    for each, tag in CLOSING_REGEX.findall(html):
-        html = html.replace(
-            each,
-            each.replace('/>', '></%s>' % tag)
-        )
     if collect_stats:
         html = re.sub(
             '<body[^>]*>',