Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and further develop BaseCrawler, rewrite HttpHeadResponse #30

Closed
peterbencze opened this issue Sep 6, 2016 · 0 comments
Closed
Assignees

Comments

@peterbencze
Copy link
Owner

peterbencze commented Sep 6, 2016

  • BaseCrawler

Callback methods do not need to be abstract (template pattern).
The driver should always be closed, even if an exception occurs.
Rename onUrlOpen to onBrowserOpen
Rename onEnd to onFinish

Add new callback: onBrowserTimeout - this method is called when the request times out in the browser.
Add new public method: stop - this method is used to stop the crawler.

  • HttpHeadResponse

This class will be used as a parameter in specific callbacks. It should contain the URL of the response and all the non-setter methods that HttpResponse provides.

@peterbencze peterbencze self-assigned this Sep 6, 2016
@peterbencze peterbencze changed the title Refactor BaseCrawler Refactor, further develop BaseCrawler, rewrite HttpHeadResponse Sep 6, 2016
@peterbencze peterbencze changed the title Refactor, further develop BaseCrawler, rewrite HttpHeadResponse Refactor and further develop BaseCrawler, rewrite HttpHeadResponse Sep 6, 2016
@kmozsi kmozsi closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants