Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with frame explanation #267

Closed
vinayak-mehta opened this issue Aug 23, 2020 · 2 comments
Closed

Update docs with frame explanation #267

vinayak-mehta opened this issue Aug 23, 2020 · 2 comments
Assignees

Comments

@vinayak-mehta
Copy link

vinayak-mehta commented Aug 23, 2020

Is your feature request related to a problem? Please describe.

Opening this issue based on the Gitter conversation.

Describe the solution you'd like

I think the docs here could be updated with a better explanation of where frames lie in the Screen/Scene/Effect hierarchy, how they're different from the Frame object, along with an example of how we can use start_frame and stop_frame to time changes inside a Scene.

Describe alternatives you've considered

NA

Additional context

NA


Thanks again for asciimatics!

@peterbrittain
Copy link
Owner

Thanks. I'll try to fix that this week.

In the meantime, please feel free to submit your current code for #263 and we can discuss tweaks in that PR.

@vinayak-mehta
Copy link
Author

Thanks! I'll submit the current code on #263 today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants