New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of Quaternion.vec_xyzs #30

Merged

petercorke merged 1 commit into bdaiinstitute:master from btalb:fix/vec_xyzs

Nov 2, 2021

Contributor

btalb commented Oct 18, 2021

The vec and vec_xyzs fields of the Quaternion class currently return the same 4-vector (s, x, y, z).

This pull request updates vec_xyzs to return (x, y, z, s).


          Use np.roll() for Quaternion.vec_xyzs

63f4074

btalb changed the title ~~Use np.roll() for Quaternion.vec_xyzs~~ Fix implementation of Quaternion.vec_xyzs

petercorke merged commit 1d21d52 into bdaiinstitute:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment