Fix __ne__ error, and add opinionated change to __eq__, in BasePoseMatrix
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two parts.
1. Error in
!=
comparisonsComparing two of most things using the
!=
operator currently fails with the following error unless you make them lists:This is due to
__ne__
assuming comparison results are a list. Commit 13d6ee1 addresses this.2. An opinionated change to
==
comparisonsCurrently a runtime assertion error is thrown if two things are compared of different types.
I know I would find simply receive a
False
return easier to work with in code, as two different types definitely aren't equal. But that's just one opinion, and I can see how the way it currently is also makes sense.Happy for this part of the PR to be reverted if desired: